[Ocfs2-devel] [PATCH] ocfs2: adds mlogs to aops.c -V3
Wengang Wang
wen.gang.wang at oracle.com
Fri Aug 28 00:40:21 PDT 2009
Joel Becker wrote:
> On Fri, Aug 28, 2009 at 03:00:40PM +0800, Wengang Wang wrote:
>>>> and for the patch its self, I think the log contents are for developers
>>>> to check(not for customer to view), so we can know what are printed by
>>>> checking the src... so I am printing some parameters without pointing
>>>> out what they are.
>>> Yeah, I just don't know that we care :-
>> Oh, excuse for my poor English :P, what do you mean here?
>> you think it's OK that we don't point out what are printed? or you think
>> we should point them out exactly in log contents?
>
> Sunil is right that developers will know what was printed and
> that we don't need to be terribly detailed about that. I'm saying that
> I don't know that entry/exit logs are useful. We never turn them on
> because they are too noisy.
Ok. Then I will pick up the mlog_error()s and mlog(ERR...)s and re-post
later...
More information about the Ocfs2-devel
mailing list