[Ocfs2-devel] Re: [Ocfs2-commits] manish commits r2175 - in trunk/fs/ocfs2: . cluster dlm

[Manish Singh]

On Tue, Apr 26, 2005 at 10:20:33AM +0200, Christoph Hellwig wrote:
> On Tue, Apr 26, 2005 at 01:15:38AM -0700, Manish Singh wrote:
> > The issue here is format string readability vs. printk argument
> > readability. Both magic format defines and verbose (unsigned long long)
> > casts make the code harder to read. Why is format string readability
> > preferred?
> 
> I don't know ;-)  But if magic format strings we preferred we'd have
> them in a common place.

Perhaps they should be in some common place then? The kernel could
provide the C99 macros for dealing with explicitly sized types.

It sounds like the reason it doesn't exist already is simply because
nobody has done it yet. Printing 64-bit types in non-arch specific code
is rare in the current kernel tree, which is probably why nobody has
cared yet. I don't really see any evidence of a specific precedent set
against doing so.

-Manish