[Ocfs2-devel] Re: [Ocfs2-commits] manish commits r2175 - in trunk/fs/ocfs2: . cluster dlm

[Christoph Hellwig]

On Tue, Apr 26, 2005 at 01:15:38AM -0700, Manish Singh wrote:
> > Standard kernel practice is to cast a u64 to unsigned long (and a s64 to
> > long), and not using such obsfucation.  I'd strongly suggest to follow
> > that lead in ocfs.
> 
> I assume you meant to say "unsigned long long" and "long long".

Yes.

> The issue here is format string readability vs. printk argument
> readability. Both magic format defines and verbose (unsigned long long)
> casts make the code harder to read. Why is format string readability
> preferred?

I don't know ;-)  But if magic format strings we preferred we'd have
them in a common place.