[Ocfs2-devel] Converting some macros to inline functions

[Rusty Lynch]

On Wed, Mar 10, 2004 at 06:26:50PM -0800, Kurt Hackel wrote:
> heh.  yeah good idea.  the only ones we might turn down would be those
> that we really need to be macros for debugging purposes (need to be able
> to get at stuff like __FILE__ and __LINE__ of the calling func).
> there shouldn't be too many that need that tho, so we'll likely approve
> most of them.
> -k
> 

I have a patch that I am working on that fixes the 2.6 use of inode's union
for private data that moves a bunch of macros to inline functions.  Hopefully
I'll have it working real soon.

    --rusty

> On Wed, Mar 10, 2004 at 06:13:39PM -0800, Mark Fasheh wrote:
> > On Wed, Mar 10, 2004 at 06:03:46PM -0800, Villalovos, John L wrote:
> > > If I were to submit some patches that converted some of the macros to
> > > inline functions would it be accepted?
> > > 
> > > I just prefer to have actual functions so that we get more type
> > > checking.  Plus it gives me a chance to learn more about the code as I
> > > do it.
> > > 
> > > Any comments?
> > 
> > John,
> > 	That's the worst idea I've ever heard.
> > 
> > Just kidding. We've been meaning to do that for a while actually :)
> > So go ahead, we'd definitely be interested in those patches!
> > 	--Mark
> > 
> > --
> > Mark Fasheh
> > Software Developer, Oracle Corp
> > mark.fasheh at oracle.com
> > _______________________________________________
> > Ocfs2-devel mailing list
> > Ocfs2-devel at oss.oracle.com
> > http://oss.oracle.com/mailman/listinfo/ocfs2-devel
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel