[Ocfs2-devel] Converting some macros to inline functions

Kurt Hackel Kurt.Hackel at oracle.com
Wed Mar 10 18:26:50 CST 2004


heh.  yeah good idea.  the only ones we might turn down would be those
that we really need to be macros for debugging purposes (need to be able
to get at stuff like __FILE__ and __LINE__ of the calling func).
there shouldn't be too many that need that tho, so we'll likely approve
most of them.
-k

On Wed, Mar 10, 2004 at 06:13:39PM -0800, Mark Fasheh wrote:
> On Wed, Mar 10, 2004 at 06:03:46PM -0800, Villalovos, John L wrote:
> > If I were to submit some patches that converted some of the macros to
> > inline functions would it be accepted?
> > 
> > I just prefer to have actual functions so that we get more type
> > checking.  Plus it gives me a chance to learn more about the code as I
> > do it.
> > 
> > Any comments?
> 
> John,
> 	That's the worst idea I've ever heard.
> 
> Just kidding. We've been meaning to do that for a while actually :)
> So go ahead, we'd definitely be interested in those patches!
> 	--Mark
> 
> --
> Mark Fasheh
> Software Developer, Oracle Corp
> mark.fasheh at oracle.com
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel


More information about the Ocfs2-devel mailing list