[fedfs-utils] [PATCH 05/17] nfsref: Fix memory leak in nfsref_add_build_fsl()

Chuck Lever chuck.lever at oracle.com
Tue May 27 08:37:06 PDT 2014


Fixes: 538e6282ff68e838763bc30aeeae41c5ec309ca9
Signed-off-by: Chuck Lever <chuck.lever at oracle.com>
---
 src/nfsref/add.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/nfsref/add.c b/src/nfsref/add.c
index 8e925cc057e0..848d1d4f0f95 100644
--- a/src/nfsref/add.c
+++ b/src/nfsref/add.c
@@ -376,8 +376,10 @@ nfsref_add_build_fsl(const char *fsn_uuid, const char *server,
 	strncpy(new->fl_fsnuuid, fsn_uuid, sizeof(new->fl_fsnuuid));
 
 	retval = nfsref_add_nfs_fsl_defaults(server, rootpath, &new->fl_u.fl_nfsfsl);
-	if (retval != FEDFS_OK)
+	if (retval != FEDFS_OK) {
+		nsdb_free_fedfs_fsl(new);
 		return retval;
+	}
 
 	*fsl = new;
 	return FEDFS_OK;




More information about the fedfs-utils-devel mailing list