[fedfs-utils] [PATCH 04/17] libnsdb: Fix possible buffer overrun in nsdb_parse_nfs_uri_fsl()
Chuck Lever
chuck.lever at oracle.com
Tue May 27 08:36:58 PDT 2014
Ensure the contents placed in string[] will always be
'\0'-terminated.
Fixes: 04a9ffdfdb3ae73724b4293eade7d7c9dc342d8f
Signed-off-by: Chuck Lever <chuck.lever at oracle.com>
---
src/libnsdb/fileserver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libnsdb/fileserver.c b/src/libnsdb/fileserver.c
index 96fad2c5e1ee..ddc21a6a5fd5 100644
--- a/src/libnsdb/fileserver.c
+++ b/src/libnsdb/fileserver.c
@@ -761,7 +761,7 @@ nsdb_parse_nfs_uri_fsl(const char *attr, UriUriA *uri,
size_t portlen;
portlen = uri->portText.afterLast - uri->portText.first;
- if (portlen > sizeof(string)) {
+ if (portlen > sizeof(string) - 1) {
xlog(L_ERROR, "%s: NFS URI has invalid port",
__func__, attr);
goto out;
More information about the fedfs-utils-devel
mailing list