[DTrace-devel] [PATCH] demo: remove demo script depending on non-Linux OS features

[Eugene Loh]

On 7/24/25 12:44, Kris Van Hees wrote:

> On Thu, Jul 24, 2025 at 12:32:42PM -0400, Eugene Loh wrote:
>> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
>>
>> I do not object to this patch.  I simply do not understand its limited
>> scope:
>>
>> $ git grep -i solaris test/ | grep skip
>> test/demo/buf/ring.d:/* @@skip: Solaris-specific, unconverted */
>> test/demo/struct/kstat.d:/* @@skip: solaris-specific, not yet converted */
>> test/demo/struct/ksyms.d:/* @@skip: Solaris-specific, unconverted */
>> test/demo/sysinfo/find.d:/* @@skip: Solaris-specific, unconverted */
>> test/unittest/predicates/tst.predcache.sh:# @@skip: Solaris specific -
>> requires rewriting
> A particular problem needing a particulr fix.
>
> The ones you mention may or may not be rewritten in the future.  But they
> are not currently posing an issue that needs fixing.  This one (even though
> it is skipped) was causing packaging warnings.

Not a big deal, but could be nice to mention in commit msg.