[DTrace-devel] [PATCH] demo: remove demo script depending on non-Linux OS features

[Kris Van Hees]

On Thu, Jul 24, 2025 at 12:32:42PM -0400, Eugene Loh wrote:
> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
> 
> I do not object to this patch.  I simply do not understand its limited
> scope:
> 
> $ git grep -i solaris test/ | grep skip
> test/demo/buf/ring.d:/* @@skip: Solaris-specific, unconverted */
> test/demo/struct/kstat.d:/* @@skip: solaris-specific, not yet converted */
> test/demo/struct/ksyms.d:/* @@skip: Solaris-specific, unconverted */
> test/demo/sysinfo/find.d:/* @@skip: Solaris-specific, unconverted */
> test/unittest/predicates/tst.predcache.sh:# @@skip: Solaris specific -
> requires rewriting

A particular problem needing a particulr fix.

The ones you mention may or may not be rewritten in the future.  But they
are not currently posing an issue that needs fixing.  This one (even though
it is skipped) was causing packaging warnings.

> On 7/24/25 11:50, Kris Van Hees via DTrace-devel wrote:
> 
> > Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> > ---
> >   test/demo/struct/kstat.d | 29 -----------------------------
> >   test/demo/struct/kstat.t |  1 -
> >   2 files changed, 30 deletions(-)
> >   delete mode 100644 test/demo/struct/kstat.d
> >   delete mode 120000 test/demo/struct/kstat.t
> > 
> > diff --git a/test/demo/struct/kstat.d b/test/demo/struct/kstat.d
> > deleted file mode 100644
> > index 1ccc3bb4..00000000
> > --- a/test/demo/struct/kstat.d
> > +++ /dev/null
> > @@ -1,29 +0,0 @@
> > -/*
> > - * Oracle Linux DTrace.
> > - * Copyright (c) 2005, 2020, Oracle and/or its affiliates. All rights reserved.
> > - * Licensed under the Universal Permissive License v 1.0 as shown at
> > - * http://oss.oracle.com/licenses/upl.
> > - */
> > -
> > -/* @@runtest-opts: -q $_pid */
> > -/* @@xfail: userspace tracing not implemented */
> > -/* @@skip: solaris-specific, not yet converted */
> > -
> > -pid$1:libkstat:kstat_data_lookup:entry
> > -{
> > -	self->ksname = arg1;
> > -}
> > -
> > -pid$1:libkstat:kstat_data_lookup:return
> > -/self->ksname != NULL && arg1 != NULL/
> > -{
> > -	this->ksp = (kstat_named_t *)copyin(arg1, sizeof(kstat_named_t));
> > -	printf("%s has ui64 value %u\n",
> > -	    copyinstr(self->ksname), this->ksp->value.ui64);
> > -}
> > -
> > -pid$1:libkstat:kstat_data_lookup:return
> > -/self->ksname != NULL && arg1 == NULL/
> > -{
> > -	self->ksname = NULL;
> > -}
> > diff --git a/test/demo/struct/kstat.t b/test/demo/struct/kstat.t
> > deleted file mode 120000
> > index e9f7e5b7..00000000
> > --- a/test/demo/struct/kstat.t
> > +++ /dev/null
> > @@ -1 +0,0 @@
> > -/usr/bin/mpstat
> > \ No newline at end of file