[DTrace-devel] [PATCH 02/14] pkgconfig: drop spaces in variable decls

Nick Alcock nick.alcock at oracle.com
Mon Oct 28 16:16:28 UTC 2024


On 25 Oct 2024, Kris Van Hees said:

> On Thu, Oct 24, 2024 at 12:37:46PM +0100, Nick Alcock wrote:
>> The requirement to have variable declarations with no spaces in them is not
>> documented, nor does pkg-config seem to care, but most pkg-config scripts in
>> the wild conform to it and pkgconf --validate complains.
>> 
>> (pkgconf --validate may also complain about the Version lines. This is a bug
>> in pkgconf, <https://todo.sr.ht/~kaniini/pkgconf/15>, and should be
>> ignored.)
>> 
>> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
>> Bug: https://github.com/oracle/dtrace-utils/issues/105
>
> Move Bug before Signed-off-by, for clarity and consistency?

I kept on oscillating on that. I'll shuffle them all.

> Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

Thanks!



More information about the DTrace-devel mailing list