[DTrace-devel] [PATCH 02/14] pkgconfig: drop spaces in variable decls

[Kris Van Hees]

On Thu, Oct 24, 2024 at 12:37:46PM +0100, Nick Alcock wrote:
> The requirement to have variable declarations with no spaces in them is not
> documented, nor does pkg-config seem to care, but most pkg-config scripts in
> the wild conform to it and pkgconf --validate complains.
> 
> (pkgconf --validate may also complain about the Version lines. This is a bug
> in pkgconf, <https://todo.sr.ht/~kaniini/pkgconf/15>, and should be
> ignored.)
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> Bug: https://github.com/oracle/dtrace-utils/issues/105

Move Bug before Signed-off-by, for clarity and consistency?

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  uts/dtrace.pc.in     | 6 +++---
>  uts/dtrace_sdt.pc.in | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/uts/dtrace.pc.in b/uts/dtrace.pc.in
> index 9977082c5a7c..fda6f755166d 100644
> --- a/uts/dtrace.pc.in
> +++ b/uts/dtrace.pc.in
> @@ -1,6 +1,6 @@
> -includedir = @INCLUDEDIR@
> -libdir = @LIBDIR@
> -dtrace = @DTRACE@
> +includedir=@INCLUDEDIR@
> +libdir=@LIBDIR@
> +dtrace=@DTRACE@
>  
>  Name: DTrace
>  Description: DTrace consumer headers
> diff --git a/uts/dtrace_sdt.pc.in b/uts/dtrace_sdt.pc.in
> index 32474bc3f75d..90977661b761 100644
> --- a/uts/dtrace_sdt.pc.in
> +++ b/uts/dtrace_sdt.pc.in
> @@ -1,5 +1,5 @@
> -sdtincludedir = @SDTINCLUDEDIR@
> -dtrace = @DTRACE@
> +sdtincludedir=@SDTINCLUDEDIR@
> +dtrace=@DTRACE@
>  
>  Name: DTrace SDT
>  Description: DTrace raw SDT headers
> -- 
> 2.46.0.278.g36e3a12567
>