[rds-devel] Please pull RDS

[Vladimir Sokolovsky]

Olaf Kirch wrote:
> Grmbl, I mistyped the rds-devel list addr in the first attempt :-/
> 
> ---8<---- snip ----8<---
> 
> Hi Vlad,
> 
Hi Olaf,
> can you please pull from the following trees
> 
> git://git-openfabrics.org/~okir/ofed_1_3/rds-tools.git code-drop-20080703
> 	This reverts commit 804de7023165fd3fe89af6aac94843f195a23e72.
>  
>  	This patch would result in calls to try_to_del_timer_sync from the send
>  	CQ handler. However, it is not legal to call this from an interrupt
>  	context - it causes live locks (proven :-)

There is no code-drop-20080703 branch in the ~okir/ofed_1_3/rds-tools.git ...

> 
> git://git-openfabrics.org/~okir/ofed_1_4/linux-2.6.git code-drop-20080703
> 	Lots of patches - partly forward porting changes to 1.3, partly
> 	fixing things to make them compile on current kernels, and partly
> 	new stuff.
> 
> 	None of this is new; it has all been discussed before AFAIK -
> 	I just rolled it into one consistent patch set for ofed 1.4 now.
> 

Please prepare backport patches for kernels <= 2.6.24:

   gcc -Wp,-MD,/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/.ib_sysctl.o.d  -nostdinc -isystem /usr/lib/gcc/x86_64-redhat-linux/4.1.1/include -D__KERNEL__ -include 
include/linux/autoconf.h  -include /tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/include/linux/autoconf.h 
-I/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/kernel_addons/backport/2.6.24/include/  -include 
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/drivers/infiniband/debug/mtrack.h  -Werror-implicit-function-declaration 
-I/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/include  -I/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/drivers/infiniband/debug  -I/usr/local/include/scst 
-I/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/drivers/infiniband/ulp/srpt  -I/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/drivers/net/cxgb3  -Iinclude     -Wall -Wundef 
-Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Os  -mtune=generic -m64 -mno-red-zone -mcmodel=kernel -pipe -Wno-sign-compare 
-fno-asynchronous-unwind-tables -funit-at-a-time -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -maccumulate-outgoing-args -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -fomit-frame-pointer -g 
-fno-stack-protector -Wdeclaration-after-statement -Wno-pointer-sign    -DMODULE -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(ib_sysctl)"  -D"KBUILD_MODNAME=KBUILD_STR(rds)" -c -o 
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.o /tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:118: error: array type has incomplete element type
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:119: error: field name not in record or union initializer
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:119: error: (near initialization for 'rds_ib_sysctl_path')
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:119: error: field name not in record or union initializer
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:119: error: (near initialization for 'rds_ib_sysctl_path')
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:120: error: field name not in record or union initializer
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:120: error: (near initialization for 'rds_ib_sysctl_path')
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:120: error: field name not in record or union initializer
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:120: error: (near initialization for 'rds_ib_sysctl_path')
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:121: error: field name not in record or union initializer
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:121: error: (near initialization for 'rds_ib_sysctl_path')
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:121: error: field name not in record or union initializer
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:121: error: (near initialization for 'rds_ib_sysctl_path')
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c: In function 'rds_ib_sysctl_init':
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:133: error: implicit declaration of function 'register_sysctl_paths'
/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.c:133: warning: assignment makes pointer from integer without a cast
make[3]: *** [/tmp/ofa_1_4_dev_kernel-20080706-1038_linux-2.6.24.3_check/net/rds/ib_sysctl.o] Error 1


> git://git-openfabrics.org/~okir/ofed_1_4/rds-tools.git ofed_1_4
> 	Misc patches improving rds-stress in minor ways
> 

Pulled.
Can you update rds-tools' version? We have different features set/code for OFED-1.3 and OFED-1.4 but the same version.

> Thanks
> Olaf

Regards,
Vladimir