[rds-devel] [RFC] [PATCH] RDS: Added module parameter to enable/disable RDMA operations support

[Or Gerlitz]

Vladimir Sokolovsky wrote:
> Please review the following patch:
> RDS: Added module parameter 'rds_rdma_support' that enables/disables
> RDMA operations support.

Vlad,

I see that you have chosen to simply completely ignore my comment and 
commit this patch so its distributed with OFED 1.3 now. I would say its 
a somehow weird approach to Linux kernel / open source development... 
what's the story here?

Or.
> Signed-off-by: Vladimir Sokolovsky <vlad at mellanox.co.il>
> ---
> diff --git a/net/rds/af_rds.c b/net/rds/af_rds.c
> index a700dfb..12c9457 100644
> --- a/net/rds/af_rds.c
> +++ b/net/rds/af_rds.c
> @@ -40,6 +40,11 @@
>  #include "rds.h"
>  #include "rdma.h"
> 
> +static int rds_rdma_support = 1;
> +
> +module_param(rds_rdma_support, int, 0444);
> +MODULE_PARM_DESC(rds_rdma_support, " Enable RDMA operations support");
> +
>  /* this is just used for stats gathering :/ */
>  static spinlock_t rds_sock_lock = SPIN_LOCK_UNLOCKED;
>  unsigned long rds_sock_count;
> @@ -214,13 +219,22 @@ static int rds_setsockopt(struct socket *sock, int 
> level, int optname,
>                         ret = rds_cancel_sent_to(rs, optval, optlen);
>                         break;
>                 case RDS_GET_MR:
> -                       ret = rds_get_mr(rs, optval, optlen);
> +                       if (rds_rdma_support)
> +                               ret = rds_get_mr(rs, optval, optlen);
> +                       else
> +                               ret = -EOPNOTSUPP;
>                         break;
>                 case RDS_FREE_MR:
> -                       ret = rds_free_mr(rs, optval, optlen);
> +                       if (rds_rdma_support)
> +                               ret = rds_free_mr(rs, optval, optlen);
> +                       else
> +                               ret = -EOPNOTSUPP;
>                         break;
>                 case RDS_BARRIER:
> -                       ret = rds_barrier(rs, optval, optlen);
> +                       if (rds_rdma_support)
> +                               ret = rds_barrier(rs, optval, optlen);
> +                       else
> +                               ret = -EOPNOTSUPP;
>                         break;
>                 default:
>                         ret = -ENOPROTOOPT;
> 
> 
> _______________________________________________
> rds-devel mailing list
> rds-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/rds-devel