[Ocfs2-devel] + fs-convert-block_commit_write-to-return-void.patch added to mm-unstable branch
Andrew Morton
akpm at linux-foundation.org
Sun Jul 2 23:18:19 UTC 2023
The patch titled
Subject: fs: convert block_commit_write to return void
has been added to the -mm mm-unstable branch. Its filename is
fs-convert-block_commit_write-to-return-void.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/fs-convert-block_commit_write-to-return-void.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Bean Huo <beanhuo at micron.com>
Subject: fs: convert block_commit_write to return void
Date: Mon, 26 Jun 2023 07:55:18 +0200
block_commit_write() always returns 0, this patch changes it to return
void.
Link: https://lkml.kernel.org/r/20230626055518.842392-3-beanhuo@iokpp.de
Signed-off-by: Bean Huo <beanhuo at micron.com>
Reviewed-by: Jan Kara <jack at suse.cz>
Acked-by: Theodore Ts'o <tytso at mit.edu>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Reviewed-by: Matthew Wilcox (Oracle) <willy at infradead.org>
Cc: Al Viro <viro at zeniv.linux.org.uk>
Cc: Andreas Dilger <adilger.kernel at dilger.ca>
Cc: Christian Brauner <brauner at kernel.org>
Cc: Joel Becker <jlbec at evilplan.org>
Cc: Joseph Qi <joseph.qi at linux.alibaba.com>
Cc: LuÃs Henriques <ocfs2-devel at oss.oracle.com>
Cc: Mark Fasheh <mark at fasheh.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
---
fs/buffer.c | 14 ++++++--------
fs/ext4/move_extent.c | 7 ++-----
fs/ocfs2/file.c | 7 +------
fs/udf/file.c | 6 +++---
include/linux/buffer_head.h | 2 +-
5 files changed, 13 insertions(+), 23 deletions(-)
--- a/fs/buffer.c~fs-convert-block_commit_write-to-return-void
+++ a/fs/buffer.c
@@ -2180,7 +2180,7 @@ int __block_write_begin(struct page *pag
}
EXPORT_SYMBOL(__block_write_begin);
-static int __block_commit_write(struct folio *folio, size_t from, size_t to)
+static void __block_commit_write(struct folio *folio, size_t from, size_t to)
{
size_t block_start, block_end;
bool partial = false;
@@ -2215,7 +2215,6 @@ static int __block_commit_write(struct f
*/
if (!partial)
folio_mark_uptodate(folio);
- return 0;
}
/*
@@ -2597,11 +2596,10 @@ int cont_write_begin(struct file *file,
}
EXPORT_SYMBOL(cont_write_begin);
-int block_commit_write(struct page *page, unsigned from, unsigned to)
+void block_commit_write(struct page *page, unsigned from, unsigned to)
{
struct folio *folio = page_folio(page);
__block_commit_write(folio, from, to);
- return 0;
}
EXPORT_SYMBOL(block_commit_write);
@@ -2647,11 +2645,11 @@ int block_page_mkwrite(struct vm_area_st
end = size - folio_pos(folio);
ret = __block_write_begin_int(folio, 0, end, get_block, NULL);
- if (!ret)
- ret = __block_commit_write(folio, 0, end);
+ if (unlikely(ret))
+ goto out_unlock;
+
+ __block_commit_write(folio, 0, end);
- if (unlikely(ret < 0))
- goto out_unlock;
folio_mark_dirty(folio);
folio_wait_stable(folio);
return 0;
--- a/fs/ext4/move_extent.c~fs-convert-block_commit_write-to-return-void
+++ a/fs/ext4/move_extent.c
@@ -388,14 +388,11 @@ data_copy:
for (i = 0; i < block_len_in_page; i++) {
*err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0);
if (*err < 0)
- break;
+ goto repair_branches;
bh = bh->b_this_page;
}
- if (!*err)
- *err = block_commit_write(&folio[0]->page, from, from + replaced_size);
- if (unlikely(*err < 0))
- goto repair_branches;
+ block_commit_write(&folio[0]->page, from, from + replaced_size);
/* Even in case of data=writeback it is reasonable to pin
* inode to transaction, to prevent unexpected data loss */
--- a/fs/ocfs2/file.c~fs-convert-block_commit_write-to-return-void
+++ a/fs/ocfs2/file.c
@@ -808,12 +808,7 @@ static int ocfs2_write_zero_page(struct
/* must not update i_size! */
- ret = block_commit_write(page, block_start + 1,
- block_start + 1);
- if (ret < 0)
- mlog_errno(ret);
- else
- ret = 0;
+ block_commit_write(page, block_start + 1, block_start + 1);
}
/*
--- a/fs/udf/file.c~fs-convert-block_commit_write-to-return-void
+++ a/fs/udf/file.c
@@ -63,13 +63,13 @@ static vm_fault_t udf_page_mkwrite(struc
else
end = PAGE_SIZE;
err = __block_write_begin(page, 0, end, udf_get_block);
- if (!err)
- err = block_commit_write(page, 0, end);
- if (err < 0) {
+ if (err) {
unlock_page(page);
ret = block_page_mkwrite_return(err);
goto out_unlock;
}
+
+ block_commit_write(page, 0, end);
out_dirty:
set_page_dirty(page);
wait_for_stable_page(page);
--- a/include/linux/buffer_head.h~fs-convert-block_commit_write-to-return-void
+++ a/include/linux/buffer_head.h
@@ -288,7 +288,7 @@ int cont_write_begin(struct file *, stru
unsigned, struct page **, void **,
get_block_t *, loff_t *);
int generic_cont_expand_simple(struct inode *inode, loff_t size);
-int block_commit_write(struct page *page, unsigned from, unsigned to);
+void block_commit_write(struct page *page, unsigned int from, unsigned int to);
int block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf,
get_block_t get_block);
/* Convert errno to return value from ->page_mkwrite() call */
_
Patches currently in -mm which might be from beanhuo at micron.com are
fs-buffer-clean-up-block_commit_write.patch
fs-convert-block_commit_write-to-return-void.patch
More information about the Ocfs2-devel
mailing list