[Ocfs2-devel] + fs-buffer-clean-up-block_commit_write.patch added to mm-unstable branch

Andrew Morton akpm at linux-foundation.org
Sun Jul 2 23:18:17 UTC 2023


The patch titled
     Subject: fs/buffer: clean up block_commit_write
has been added to the -mm mm-unstable branch.  Its filename is
     fs-buffer-clean-up-block_commit_write.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/fs-buffer-clean-up-block_commit_write.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Bean Huo <beanhuo at micron.com>
Subject: fs/buffer: clean up block_commit_write
Date: Mon, 26 Jun 2023 07:55:17 +0200

Originally inode is used to get blksize, after commit 45bce8f3e343
("fs/buffer.c: make block-size be per-page and protected by the page
lock"), __block_commit_write no longer uses this parameter inode.

Link: https://lkml.kernel.org/r/20230626055518.842392-2-beanhuo@iokpp.de
Signed-off-by: Bean Huo <beanhuo at micron.com>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Reviewed-by: Matthew Wilcox (Oracle) <willy at infradead.org>
Reviewed-by: Jan Kara <jack at suse.cz>
Cc: Al Viro <viro at zeniv.linux.org.uk>
Cc: Andreas Dilger <adilger.kernel at dilger.ca>
Cc: Christian Brauner <brauner at kernel.org>
Cc: Joel Becker <jlbec at evilplan.org>
Cc: Joseph Qi <joseph.qi at linux.alibaba.com>
Cc: Luís Henriques <ocfs2-devel at oss.oracle.com>
Cc: Mark Fasheh <mark at fasheh.com>
Cc: Theodore Ts'o <tytso at mit.edu>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
---

 fs/buffer.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

--- a/fs/buffer.c~fs-buffer-clean-up-block_commit_write
+++ a/fs/buffer.c
@@ -2180,8 +2180,7 @@ int __block_write_begin(struct page *pag
 }
 EXPORT_SYMBOL(__block_write_begin);
 
-static int __block_commit_write(struct inode *inode, struct folio *folio,
-		size_t from, size_t to)
+static int __block_commit_write(struct folio *folio, size_t from, size_t to)
 {
 	size_t block_start, block_end;
 	bool partial = false;
@@ -2277,7 +2276,7 @@ int block_write_end(struct file *file, s
 	flush_dcache_folio(folio);
 
 	/* This could be a short (even 0-length) commit */
-	__block_commit_write(inode, folio, start, start + copied);
+	__block_commit_write(folio, start, start + copied);
 
 	return copied;
 }
@@ -2601,8 +2600,7 @@ EXPORT_SYMBOL(cont_write_begin);
 int block_commit_write(struct page *page, unsigned from, unsigned to)
 {
 	struct folio *folio = page_folio(page);
-	struct inode *inode = folio->mapping->host;
-	__block_commit_write(inode, folio, from, to);
+	__block_commit_write(folio, from, to);
 	return 0;
 }
 EXPORT_SYMBOL(block_commit_write);
@@ -2650,7 +2648,7 @@ int block_page_mkwrite(struct vm_area_st
 
 	ret = __block_write_begin_int(folio, 0, end, get_block, NULL);
 	if (!ret)
-		ret = __block_commit_write(inode, folio, 0, end);
+		ret = __block_commit_write(folio, 0, end);
 
 	if (unlikely(ret < 0))
 		goto out_unlock;
_

Patches currently in -mm which might be from beanhuo at micron.com are

fs-buffer-clean-up-block_commit_write.patch
fs-convert-block_commit_write-to-return-void.patch




More information about the Ocfs2-devel mailing list