[DTrace-devel] [PATCH v3 8/9] build: add configure script
Nick Alcock
nick.alcock at oracle.com
Fri Feb 2 17:34:00 UTC 2024
On 31 Jan 2024, Kris Van Hees uttered the following:
> On Wed, Jan 31, 2024 at 03:59:50PM +0000, Nick Alcock via DTrace-devel wrote:
>> On 30 Jan 2024, Kris Van Hees told this:
>>
>> > On Fri, Jan 26, 2024 at 01:58:48PM +0000, Nick Alcock wrote:
>> >> + --kernel-mod-dir=*) write_make_var KERNEL_MOD_DIR "$option";;
>> >> + --kernel-src-dir=*) write_make_var KERNEL_SRC_DIR "$option";;
>> >> + --kernel-obj-dir=*) write_make_var KERNEL_OBJ_DIR "$option";;
>> >
>> > You seem to have missed the comments on this... These make variables do not
>> > actually exist. We use KERNELMODDIR, KERNELSRCDIR, and KERNELOBJDIR. So those
>> > are the ones that ought to be set here (the --kernel-*-dir option names are ok
>> > to use I think).
>>
>> Whoops! I had a fix for this and accidentally dropped it rather than
>> quashing it in. Will send another round...
>>
>> > Should KERELSRCSUFFIX and KERNELBLDSUFFIX also be something that can be set
>> > with the configure script? (Those are introduced in a patch not part of this
>> > series.)
>>
>> Probably, yes, but I couldn't really do that until after the commit
>> introducing them had landed.
>
> If you rebase on dev you can :)
You mean KERNELSRCNAME and KERNELBLDNAME? (and is it obvious that we have
no good names for any of these things? yes, yes it is. :) )
On that.
--
NULL && (void)
More information about the DTrace-devel
mailing list