[DTrace-devel] [PATCH 1/3] test: tst.nested-unnamed-structs.d needs to be xfail pending binutils patch

[Eugene Loh]

On 5/26/23 12:08, Nick Alcock via DTrace-devel wrote:

> On 26 May 2023, Kris Van Hees via DTrace-devel said:
>
>> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> Reviewed-by: Nick Alcock <nick.alcock at oracle.com>
>
> (the patch is upstream and has been backported as far as binutils 2.40,
> but we can't rely on its being present yet.)

So someone could have 2.40 and see this xpass?  Does that mean that what 
this test really needs is a modification to its .x file instead of an 
outright xfail?

>> ---
>>   test/unittest/types/tst.nested-unnamed-structs.d | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/test/unittest/types/tst.nested-unnamed-structs.d b/test/unittest/types/tst.nested-unnamed-structs.d
>> index a2b17443..a5660d97 100644
>> --- a/test/unittest/types/tst.nested-unnamed-structs.d
>> +++ b/test/unittest/types/tst.nested-unnamed-structs.d
>> @@ -4,6 +4,7 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> +/* @@xfail: requires libctf (binutils) patch */
> It should probably be marked as @@tags: unstable too, until we have the
> patch everywhere that tests might be run on it. (Of course that's not
> needed yet, since I haven't backported it anywhere at all.)
>