[DTrace-devel] [PATCH 1/3] test: tst.nested-unnamed-structs.d needs to be xfail pending binutils patch

Nick Alcock nick.alcock at oracle.com
Fri May 26 16:08:12 UTC 2023


On 26 May 2023, Kris Van Hees via DTrace-devel said:

> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>

Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

(the patch is upstream and has been backported as far as binutils 2.40,
but we can't rely on its being present yet.)

> ---
>  test/unittest/types/tst.nested-unnamed-structs.d | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/test/unittest/types/tst.nested-unnamed-structs.d b/test/unittest/types/tst.nested-unnamed-structs.d
> index a2b17443..a5660d97 100644
> --- a/test/unittest/types/tst.nested-unnamed-structs.d
> +++ b/test/unittest/types/tst.nested-unnamed-structs.d
> @@ -4,6 +4,7 @@
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> +/* @@xfail: requires libctf (binutils) patch */

It should probably be marked as @@tags: unstable too, until we have the
patch everywhere that tests might be run on it. (Of course that's not
needed yet, since I haven't backported it anywhere at all.)

-- 
NULL && (void)



More information about the DTrace-devel mailing list