[DTrace-devel] [PATCH 12/12] test: tst.selfarray2.d should not PASS

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
but it would also be nice if the @@xfail had some explanation (more 
specific than "dtv2") why it should fail.  And probably be good to have 
a .r results file.

On 5/12/23 09:31, Kris Van Hees via DTrace-devel wrote:
> Due to the drop support triggering bad address faults, this test ended
> up reporting XPASS which it really should not.  Added an explicit ERROR
> clause to detect faults (and report failure if a fault occurs).
>
> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> ---
>   test/unittest/scalars/tst.selfarray2.d | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/test/unittest/scalars/tst.selfarray2.d b/test/unittest/scalars/tst.selfarray2.d
> index 51311dfa..3c8140d6 100644
> --- a/test/unittest/scalars/tst.selfarray2.d
> +++ b/test/unittest/scalars/tst.selfarray2.d
> @@ -1,6 +1,6 @@
>   /*
>    * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2023, Oracle and/or its affiliates. All rights reserved.
>    * Licensed under the Universal Permissive License v 1.0 as shown at
>    * http://oss.oracle.com/licenses/upl.
>    */
> @@ -44,3 +44,8 @@ tick-1sec
>   {
>   	exit(0);
>   }
> +
> +ERROR
> +{
> +	exit(1);
> +}