[DTrace-devel] [PATCH 09/14] Consolidate some tvar and assoc code
Eugene Loh
eugene.loh at oracle.com
Tue May 2 19:48:35 UTC 2023
On 5/2/23 11:58, Nick Alcock wrote:
> On 2 May 2023, eugene loh told this:
>
>> Subject: Re: [DTrace-devel] [PATCH 09/14] Consolidate some tvar and assoc code
> It might be clearer with a first line of "Consolidate tvar/assoc pointer
> access", which at least says what is being consolidated.
Good point. Change made.
> Usual caveat:
>> + /* associative arrays */
>> + uint_t varid = idp->di_id - DIF_VAR_OTHER_UBASE;
> ... about comment style. (In this case I'm only grumping about the
> capital letter:) )
Okay, capitalized.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://oss.oracle.com/pipermail/dtrace-devel/attachments/20230502/ea436f2c/attachment.html>
More information about the DTrace-devel
mailing list