[DTrace-devel] [PATCH 09/14] Consolidate some tvar and assoc code

Nick Alcock nick.alcock at oracle.com
Tue May 2 15:58:07 UTC 2023


On 2 May 2023, eugene loh told this:

> Subject: Re: [DTrace-devel] [PATCH 09/14] Consolidate some tvar and assoc code

It might be clearer with a first line of "Consolidate tvar/assoc pointer
access", which at least says what is being consolidated.

> In this patch, consolidate the pointer-access code.  In the next
> patch, we will consolidate the pointer generation.

(verified that the code generation is unchanged and that it's clearer)

> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

Usual caveat:

> +		/* associative arrays */
> +		uint_t	varid = idp->di_id - DIF_VAR_OTHER_UBASE;

... about comment style. (In this case I'm only grumping about the
capital letter :) )

-- 
NULL && (void)



More information about the DTrace-devel mailing list