[DTrace-devel] [PATCH 06/14] Move tvar code next to assoc code

[Eugene Loh]

On 5/2/23 11:49, Nick Alcock wrote:

> On 2 May 2023, eugene loh stated:
>
>> From: Eugene Loh <eugene.loh at oracle.com>
>>
>> Since the handling of thread-local variables and associative
>> arrays are so similar, move tvar code next to to assoc code.
>> In subsequent patches, common code will be consolidated.
>>
>> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> My r-bs for this commit and the three following assume that the code
> worked before:

And this patch series adds more tests.

> I have verified that the semantics are unchanged, and
> it's ever so much clearer now :)
>
> Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

Thanks.

> .... with the usual caveat:
>
>> +	/* global and local variables */
> ... that this is still not how comments are done in DTrace and that at
> the very least sentences should start with capital letters.

I appreciate the reviews and am motivated to make simple changes, but 
the practices you mention (multi-line block comments, starting with 
capitals) don't seem to be consistent practices, neither in the code 
base in general nor in recent commits in particular.  I see single-line 
comments starting with lowercase letters in both recent and older 
commits from multiple authors (though I admit I'm probably the most 
prolific "offender").

In this particular case, the comment is not new but simply being moved.  
It is also not a sentence.

And, in this particular case, since I'm only moving code but trying at 
least in this patch not to touch it otherwise, I'm inclined to leave the 
comment as is / as was.

If there's more discussion and we decide we want to do the 
capitalization of comments or whatever, I can make those changes.