[DTrace-devel] [PATCH 06/14] Move tvar code next to assoc code

Nick Alcock nick.alcock at oracle.com
Tue May 2 15:49:05 UTC 2023


On 2 May 2023, eugene loh stated:

> From: Eugene Loh <eugene.loh at oracle.com>
>
> Since the handling of thread-local variables and associative
> arrays are so similar, move tvar code next to to assoc code.
> In subsequent patches, common code will be consolidated.
>
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

My r-bs for this commit and the three following assume that the code
worked before: I have verified that the semantics are unchanged, and
it's ever so much clearer now :)

Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

.... with the usual caveat:

> +	/* global and local variables */

... that this is still not how comments are done in DTrace and that at
the very least sentences should start with capital letters.



More information about the DTrace-devel mailing list