[DTrace-devel] [PATCH 06/17] dt_link: finish backing out varint, fixing dt_link-generated object files

[Nick Alcock]

On 31 Aug 2022, Eugene Loh via DTrace-devel told this:

> I could almost convince myself I understand this patch, but I get lost in the commit message, presumably because I am not
> sufficiently familiar with the issues it discusses.

Yeah, most of this is *binutils* (specifically bfd), not dtrace at all.

> Simple question:  is there a test that fails due to the reported problem?  I would think there should be such a test as part of this
> patch.

The commit message points at it:

/usr/bin/ld: .../build/test-triggers--usdt-tst-special.o: error adding symbols: no error

I think a testcase is a bit redundant when the bug breaks the actual
build. It also breaks a bunch of usdt tests, which is why I was finally
forced to fix this. So there will be new test failures if this
regresses.

> Also, since varints are kind of history now, maybe the commit message should refer to one or more specific patches.  E.g., 29e3f422
> "Remove the string length prefix".  Otherwise, a new developer might have no idea what varints were ever about.

Done.

-- 
NULL && (void)