[DTrace-devel] [PATCH 05/17] uapi headers: include <sys/dtrace_types> as needed

[Nick Alcock]

On 31 Aug 2022, Eugene Loh via DTrace-devel spake thusly:

> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
>
> But:
>
> *)  Should we add tests?  (I'm not convinced we should -- there are too many code paths -- but see next item.)

Well... we had self-containedness tests in the old days when this stuff
was in the kernel tree, but they seem sort of pointless now the headers
are no longer public because any such error will soon bite the headers'
only remaining user.

But a test for sanity with respect to these two specific macros is easy
enough to add: done. (In a new directory, test/internals/headers, where
we can stuff other header-related tests.)

> On 8/10/22 18:06, Nick Alcock via DTrace-devel wrote:
>> This is needed for _LITTLE_ENDIAN etc: without it, consumers are liable
>> to find that they think they're on a big-endian system even when they're
>
> Think they're on a BE system?  Well, it depends on how the code is written:  the error might induce one to thinking they're on a
> little-endian machine.  Anyhow, the commit message can be written in a way that does not assume which way the #ifdef is written.

True: fixed.

-- 
NULL && (void)