[DTrace-devel] [PATCH 17/17] usdt: testsuite updates

Eugene Loh eugene.loh at oracle.com
Thu Sep 1 21:11:57 UTC 2022


And...

Should files have their copyright years updated when touched?

On 8/10/22 18:07, Nick Alcock via DTrace-devel wrote:
> diff --git a/test/unittest/usdt/tst.fork.sh b/test/unittest/usdt/tst.lingering.sh
>   if [ $# != 1 ]; then
>   	echo expected one argument: '<'dtrace-path'>'
>   	exit 2
>   fi

I think this $#!=1 check has been deprecated.  Kris says that if this is 
going to fail, there will be widespread outages anyhow.  So no point in 
checking all the time.  (Yeah, inherited from tst.fork.sh.)

> diff --git a/test/unittest/usdt/tst.reeval.sh b/test/unittest/usdt/tst.reeval.sh
> -# @@xfail: dtv2
> +# @@xfail: dtv2, no args on usdt probes yet

The message looks wrong.



More information about the DTrace-devel mailing list