[DTrace-devel] [PATCH 17/17] usdt: testsuite updates
Eugene Loh
eugene.loh at oracle.com
Thu Sep 1 20:42:57 UTC 2022
I think it'd be better to combine removal of xfail annotations with the
patches in which the tests start to pass. That way, you can see which
test goes with which patch. Also...
On 8/10/22 18:07, Nick Alcock via DTrace-devel wrote:
> We also mark three pid tests as broken which need raise(). I have no
> idea how they ever worked, but I don't think their failing now is a sign
> of a problem in USDT.
The pid tests should work.
> We add one new test to make sure that you can run a probe-containing
> program and then repeatedly probe it from multiple dtraces in turn
> without them messing up each others' probes in any way. (Doing it from
> multiple dtraces in *parallel* may well not work yet: no specific code
> has been written to make it work: that's planned for the next phase.)
Might as well phrase that paragraph in such a way that the word
"lingering" is used to tie it to the new test. Not a big deal, I know.
> diff --git a/test/unittest/usdt/tst.entryreturn.sh b/test/unittest/usdt/tst.entryreturn.sh
> +# @@xfail: dtv2, needs system()
> -# @@xfail: dtv2
No: system() works just fine, so far as I can tell.
More information about the DTrace-devel
mailing list