[DTrace-devel] [oracle/dtrace-utils] 147e59: Error out on unrecognized actions

Wed Nov 2 14:28:54 UTC 2022

  Branch: refs/heads/dev
  Home:   https://github.com/oracle/dtrace-utils
  Commit: 147e59eddb624307657f1d9030db0c2d1d63858c
      https://github.com/oracle/dtrace-utils/commit/147e59eddb624307657f1d9030db0c2d1d63858c
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M libdtrace/dt_cg.c
    M libdtrace/dt_consume.c
    M test/unittest/tracemem/tst.init_task.d
    M test/unittest/types/tst.complex.d

  Log Message:
  -----------
  Error out on unrecognized actions

Note that this patch causes a few spuriously passing tests now
to fail.  So, they must be marked XFAIL.

One odd test is tst.clearavg2.d.  It was already marked XFAIL,
with the message made even more specific in patch fb264ec9 ("test:
Annotate tests that require missing features"), indicting clear().
But the test had actually started passing a few patches earlier,
in f256db8f ("Implement setopt()"), when the consumer was modified
to skip over unrecognized DTRACEACT_LIBACT records.  So, the test
had started to XPASS, an indication of its leniency.  With the
current patch, that test now correctly XFAILs:  its behavior is
now in line with its XFAIL.

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

  Commit: 0bd5936069eae6ea63928406aeb75063283bb7b8
      https://github.com/oracle/dtrace-utils/commit/0bd5936069eae6ea63928406aeb75063283bb7b8
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M test/unittest/consumer/tst.symbols.c

  Log Message:
  -----------
  test: Speed up check for modname-symname duplicates

When we check "lookup by name", a mismatch is allowed if there are
duplicates with the same modname and symname.  So, we must be able
to detect when such duplicates occur.  We were using a linear search.

Add a quick sort by modname/symname and then initialize a field
"is_duplicate" to speed up detection of duplicates.

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

  Commit: a6506013f44c84383d1ff15bcf852b9a79a1cda2
      https://github.com/oracle/dtrace-utils/commit/a6506013f44c84383d1ff15bcf852b9a79a1cda2
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M libdtrace/dt_module.c
    M test/unittest/consumer/tst.symbols.c

  Log Message:
  -----------
  Ignore module name __builtin__kprobes in kallmodsyms

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

  Commit: 9ac7fbec3bcb58625411e27f31122afc3f4545dc
      https://github.com/oracle/dtrace-utils/commit/9ac7fbec3bcb58625411e27f31122afc3f4545dc
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M NEWS
    M dtrace.spec

  Log Message:
  -----------
  Update NEWS and spec file for errata release 2.0.0-1.11

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

  Commit: 286bdb385b7e4a589ec19d951535b29d4985347e
      https://github.com/oracle/dtrace-utils/commit/286bdb385b7e4a589ec19d951535b29d4985347e
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M dtprobed/Build
    M dtprobed/dtprobed.service
    M dtprobed/dtrace-usdt.target
    M dtrace.spec

  Log Message:
  -----------
  dtprobed: start as early as possible

We'd like to start dtprobed *before* multi-user.target so that the
majority of daemons (those started after that point, in parallel)
already find it running and can register any USDT probes they may
contain.

We also need to "systemctl enable" everything at install time, since
dtprobed et al don't appear in the presets, so start disabled by
default.  (In the specfile, we not only need to do that but prod
udev to get the udev rules loaded.  This is peculiar since udev
uses filesystem notifies to do that itself, but if that's in the
packaging standard, so be it... we even need to start the thing
by hand after installation, because the systemd macros rely on
dtprobed being named in the presets, which it is not.)

Also turn off RestrictSUIDSGID: it's a good idea but it relies
on a seccomp filter, which stops us from enabling strict seccomp
later on for dtprobed's parser child.

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

  Commit: d322b7e969909925b0d27f56a787b99b1ce4801d
      https://github.com/oracle/dtrace-utils/commit/d322b7e969909925b0d27f56a787b99b1ce4801d
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M dtrace.spec

  Log Message:
  -----------
  spec: drop references to dtrace-modules-{shared,provider}-headers

These have been dead for long enough that we no longer need to obsolete
them (fixing a fatal rpmbuild "warning" on OL9).

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

  Commit: 57f2466c80dbf97f5500387de431cdbc35f34cd9
      https://github.com/oracle/dtrace-utils/commit/57f2466c80dbf97f5500387de431cdbc35f34cd9
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M NEWS

  Log Message:
  -----------
  NEWS: mention the dtprobed daemon

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

  Commit: 9778f6566d117bbb69135cba196abec457516164
      https://github.com/oracle/dtrace-utils/commit/9778f6566d117bbb69135cba196abec457516164
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2022-11-02 (Wed, 02 Nov 2022)

  Changed paths:
    M test/unittest/consumer/addr2str-null.c
    M test/unittest/consumer/tst.merge_ranges_bug25767469.c
    M test/unittest/consumer/tst.symbols.c

  Log Message:
  -----------
  test: mark dev-only tests with the 'uninstalled' tag

These tests depend on compilation using headers that are not installed.
As such, these tests can never PASS outside the development tree,

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

Compare: https://github.com/oracle/dtrace-utils/compare/13042087779e...9778f6566d11