[DTrace-devel] [PATCH] test: mark dev-only tests with the 'uninstalled' tag

Nick Alcock nick.alcock at oracle.com
Wed Nov 2 13:55:08 UTC 2022


On 2 Nov 2022, Kris Van Hees outgrape:

> On Wed, Nov 02, 2022 at 01:44:23PM +0000, Nick Alcock wrote:
>> On 2 Nov 2022, Kris Van Hees via DTrace-devel spake thusly:
>> 
>> > These tests depend on compilation using headers that are not installed.
>> > As such, these tests can never PASS outside the development tree,
>> >
>> > Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
>> 
>> It might make more sense to put this in a
>> test/unittest/consumer/test.options?
>
> I'd rather not because, although these three tests are the only ones there
> right now, skipping things like this seems to be something we should be doing
> on an individual basis.  Otherwise, as other tests might get added to this
> directory, it is likely that it will go unnoticed that those new tests are
> skipped on installed-only testruns as well.

Oh right. I assumed it was consumer tests in general that were going
wrong. If these tests are all independently busted, then

Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

(and I'm being too pedantic, I Know it)

-- 
NULL && (void)



More information about the DTrace-devel mailing list