[DTrace-devel] [PATCH v2 14/17] alloca, tests: add test/unittest/funcs/err.badbcopy*.d expected results

[Nick Alcock]

On 24 Mar 2022, Eugene Loh via DTrace-devel said:

> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
>
> Incidentally, though I wouldn't require this patch (necessarily) to fix this problem across the test suite, might not 
> test/unittest/funcs/alloca/err.alloca-load-before-bottom.d be thrown into this patch as well?

Fixed :) but the .r is now introduced in the same place as the test, in
"alloca: deref".  This commit is just for err.badbcopy.d.

> Also, I'd be fine without the commit message.  It doesn't really say anything.  The subject line and patch body suffice.

This particular failure mode was unexpected enough (to me, anyway) that
I thought it was worth noting somewhere.

> On 3/14/22 5:30 PM, Nick Alcock wrote:
>> The lack of these nearly led to a verifier failure being overlooked
>> because a verifier failure from an err.* test with no err tag or
>> expected results just looks like a perfectly valid error.

I didn't expect verifier failures to be considered successes at all...
but in this one case they are. (We should possibly fix that? But it
might open a bit of a can of worms :P )