[DTrace-devel] [PATCH v2 14/17] alloca, tests: add test/unittest/funcs/err.badbcopy*.d expected results

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

Incidentally, though I wouldn't require this patch (necessarily) to fix 
this problem across the test suite, might not 
test/unittest/funcs/alloca/err.alloca-load-before-bottom.d be thrown 
into this patch as well?

Also, I'd be fine without the commit message.  It doesn't really say 
anything.  The subject line and patch body suffice.

On 3/14/22 5:30 PM, Nick Alcock wrote:
> The lack of these nearly led to a verifier failure being overlooked
> because a verifier failure from an err.* test with no err tag or
> expected results just looks like a perfectly valid error.
>
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>   test/unittest/funcs/err.badbcopy.r  | 3 +++
>   test/unittest/funcs/err.badbcopy1.r | 3 +++
>   test/unittest/funcs/err.badbcopy2.r | 3 +++
>   test/unittest/funcs/err.badbcopy3.r | 3 +++
>   test/unittest/funcs/err.badbcopy7.r | 3 +++
>   5 files changed, 15 insertions(+)
>   create mode 100644 test/unittest/funcs/err.badbcopy.r
>   create mode 100644 test/unittest/funcs/err.badbcopy1.r
>   create mode 100644 test/unittest/funcs/err.badbcopy2.r
>   create mode 100644 test/unittest/funcs/err.badbcopy3.r
>   create mode 100644 test/unittest/funcs/err.badbcopy7.r
>
> diff --git a/test/unittest/funcs/err.badbcopy.r b/test/unittest/funcs/err.badbcopy.r
> new file mode 100644
> index 000000000000..ef424aedd5a8
> --- /dev/null
> +++ b/test/unittest/funcs/err.badbcopy.r
> @@ -0,0 +1,3 @@
> +
> +-- @@stderr --
> +dtrace: error on enabled probe ID 3 (ID 1: dtrace:::BEGIN): invalid address ({ptr}) in action #1
> diff --git a/test/unittest/funcs/err.badbcopy1.r b/test/unittest/funcs/err.badbcopy1.r
> new file mode 100644
> index 000000000000..31cfb8f7b177
> --- /dev/null
> +++ b/test/unittest/funcs/err.badbcopy1.r
> @@ -0,0 +1,3 @@
> +
> +-- @@stderr --
> +dtrace: error on enabled probe ID 3 (ID 1: dtrace:::BEGIN): invalid size ({ptr}) in action #1
> diff --git a/test/unittest/funcs/err.badbcopy2.r b/test/unittest/funcs/err.badbcopy2.r
> new file mode 100644
> index 000000000000..ef424aedd5a8
> --- /dev/null
> +++ b/test/unittest/funcs/err.badbcopy2.r
> @@ -0,0 +1,3 @@
> +
> +-- @@stderr --
> +dtrace: error on enabled probe ID 3 (ID 1: dtrace:::BEGIN): invalid address ({ptr}) in action #1
> diff --git a/test/unittest/funcs/err.badbcopy3.r b/test/unittest/funcs/err.badbcopy3.r
> new file mode 100644
> index 000000000000..ef424aedd5a8
> --- /dev/null
> +++ b/test/unittest/funcs/err.badbcopy3.r
> @@ -0,0 +1,3 @@
> +
> +-- @@stderr --
> +dtrace: error on enabled probe ID 3 (ID 1: dtrace:::BEGIN): invalid address ({ptr}) in action #1
> diff --git a/test/unittest/funcs/err.badbcopy7.r b/test/unittest/funcs/err.badbcopy7.r
> new file mode 100644
> index 000000000000..ef424aedd5a8
> --- /dev/null
> +++ b/test/unittest/funcs/err.badbcopy7.r
> @@ -0,0 +1,3 @@
> +
> +-- @@stderr --
> +dtrace: error on enabled probe ID 3 (ID 1: dtrace:::BEGIN): invalid address ({ptr}) in action #1