[DTrace-devel] [PATCH] Move freeing %r0 to a more consistent place

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
________________________________
From: Kris Van Hees via DTrace-devel <dtrace-devel at oss.oracle.com>
Sent: Tuesday, August 23, 2022 2:49 PM
To: dtrace-devel at oss.oracle.com <dtrace-devel at oss.oracle.com>
Subject: [DTrace-devel] [PATCH] Move freeing %r0 to a more consistent place

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
---
 libdtrace/dt_cg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
index 157f4861..744af2ae 100644
--- a/libdtrace/dt_cg.c
+++ b/libdtrace/dt_cg.c
@@ -2778,14 +2778,13 @@ empty_args:
                         emit(dlp,  BPF_CALL_HELPER(BPF_FUNC_probe_read));
                         dt_regset_free_args(drp);
                         emit(dlp,  BPF_BRANCH_IMM(BPF_JEQ, BPF_REG_0, 0, lbl_valid));
+                       dt_regset_free(drp, BPF_REG_0);
                         dt_cg_probe_error(yypcb, DTRACEFLT_BADADDR,
                                           DT_ISIMM, 0);

                         emitl(dlp, lbl_valid,
                                    BPF_ALU64_IMM(BPF_ADD, treg, size));
                         tuplesize += size;
-
-                       dt_regset_free(drp, BPF_REG_0);
                 } else
                         assert(0);      /* We shouldn't be able to get here. */
         }
--
2.34.1


_______________________________________________
DTrace-devel mailing list
DTrace-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/dtrace-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://oss.oracle.com/pipermail/dtrace-devel/attachments/20220824/f9de6dd8/attachment.html>