<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Reviewed-by: Eugene Loh <eugene.loh@oracle.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Kris Van Hees via DTrace-devel <dtrace-devel@oss.oracle.com><br>
<b>Sent:</b> Tuesday, August 23, 2022 2:49 PM<br>
<b>To:</b> dtrace-devel@oss.oracle.com <dtrace-devel@oss.oracle.com><br>
<b>Subject:</b> [DTrace-devel] [PATCH] Move freeing %r0 to a more consistent place</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com><br>
---<br>
libdtrace/dt_cg.c | 3 +--<br>
1 file changed, 1 insertion(+), 2 deletions(-)<br>
<br>
diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c<br>
index 157f4861..744af2ae 100644<br>
--- a/libdtrace/dt_cg.c<br>
+++ b/libdtrace/dt_cg.c<br>
@@ -2778,14 +2778,13 @@ empty_args:<br>
emit(dlp, BPF_CALL_HELPER(BPF_FUNC_probe_read));<br>
dt_regset_free_args(drp);<br>
emit(dlp, BPF_BRANCH_IMM(BPF_JEQ, BPF_REG_0, 0, lbl_valid));<br>
+ dt_regset_free(drp, BPF_REG_0);<br>
dt_cg_probe_error(yypcb, DTRACEFLT_BADADDR,<br>
DT_ISIMM, 0);<br>
<br>
emitl(dlp, lbl_valid,<br>
BPF_ALU64_IMM(BPF_ADD, treg, size));<br>
tuplesize += size;<br>
-<br>
- dt_regset_free(drp, BPF_REG_0);<br>
} else<br>
assert(0); /* We shouldn't be able to get here. */<br>
}<br>
-- <br>
2.34.1<br>
<br>
<br>
_______________________________________________<br>
DTrace-devel mailing list<br>
DTrace-devel@oss.oracle.com<br>
<a href="https://oss.oracle.com/mailman/listinfo/dtrace-devel">https://oss.oracle.com/mailman/listinfo/dtrace-devel</a><br>
</div>
</span></font></div>
</body>
</html>