[DTrace-devel] [PATCH] Disable building USDT test triggers due to linker failures

[Kris Van Hees]

On Wed, Apr 27, 2022 at 02:04:05PM -0400, Eugene Loh via DTrace-devel wrote:
> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
> but could you add a few words to say "what linker failures?"

I'd rather not because we have not fully diagnosed the issue.  We just know
it fails and that (right now) that isn't an important issue for us because
USDT does not work yet anyway.

> Also why is usdt-tst-special redundantly commented out?

Mistake - fixed.  (OL9 only needs that one, but Debian needs them all
excluded.)

> (And to me it makes more sense to comment out the 64BIT+=64BIT_SDT line than
> the definition of 64BIT_SDT.  We're not changing the definition of
> 64BIT_SDT;  we simply don't want to include them. But clearly no biggie.)

I comment out the definition because that is less confusing when/if additional
components might be added to the EXTERNAL_64BIT_TRIGGERS target (not USDT
related).
> 
> On 4/27/22 1:49 PM, Kris Van Hees via DTrace-devel wrote:
> > Disable the EXTERNAL_64BIT_SDT_TRIGGERS targets.  Also add run-dtrace
> > as an explicit dependency for the "all" target so it gets built.  It
> > is very frequently used for development testing and was previously
> > created as a dependency for USDT triggers.
> > 
> > Signed-off-by: Kris Van Hees<kris.van.hees at oracle.com>
> > ---
> >   test/triggers/Build | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/test/triggers/Build b/test/triggers/Build
> > @@ -12,7 +14,7 @@ EXTERNAL_64BIT_TRIGGERS = testprobe readwholedir mmap bogus-ioctl open delaydie
> >       ustack-tst-spin ustack-tst-mtspin \
> >       visible-constructor visible-constructor-static visible-constructor-static-unstripped
> > -EXTERNAL_64BIT_SDT_TRIGGERS = usdt-tst-argmap usdt-tst-args usdt-tst-forker usdt-tst-special
> > +# EXTERNAL_64BIT_SDT_TRIGGERS = usdt-tst-argmap usdt-tst-args usdt-tst-forker # usdt-tst-special
> >   EXTERNAL_64BIT_TRIGGERS += $(EXTERNAL_64BIT_SDT_TRIGGERS)
> >   EXTERNAL_32BIT_TRIGGERS := visible-constructor-32
> > -- 2.34.1 _______________________________________________ DTrace-devel
> > mailing list DTrace-devel at oss.oracle.com
> > https://oss.oracle.com/mailman/listinfo/dtrace-devel
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel