[DTrace-devel] [PATCH] Disable building USDT test triggers due to linker failures

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
but could you add a few words to say "what linker failures?"

Also why is usdt-tst-special redundantly commented out?

(And to me it makes more sense to comment out the 64BIT+=64BIT_SDT line 
than the definition of 64BIT_SDT.  We're not changing the definition of 
64BIT_SDT;  we simply don't want to include them. But clearly no biggie.)

On 4/27/22 1:49 PM, Kris Van Hees via DTrace-devel wrote:
> Disable the EXTERNAL_64BIT_SDT_TRIGGERS targets.  Also add run-dtrace
> as an explicit dependency for the "all" target so it gets built.  It
> is very frequently used for development testing and was previously
> created as a dependency for USDT triggers.
>
> Signed-off-by: Kris Van Hees<kris.van.hees at oracle.com>
> ---
>   test/triggers/Build | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/test/triggers/Build b/test/triggers/Build
> @@ -12,7 +14,7 @@ EXTERNAL_64BIT_TRIGGERS = testprobe readwholedir mmap bogus-ioctl open delaydie
>       ustack-tst-spin ustack-tst-mtspin \
>       visible-constructor visible-constructor-static visible-constructor-static-unstripped
>   
> -EXTERNAL_64BIT_SDT_TRIGGERS = usdt-tst-argmap usdt-tst-args usdt-tst-forker usdt-tst-special
> +# EXTERNAL_64BIT_SDT_TRIGGERS = usdt-tst-argmap usdt-tst-args usdt-tst-forker # usdt-tst-special
>   EXTERNAL_64BIT_TRIGGERS += $(EXTERNAL_64BIT_SDT_TRIGGERS)
>   
>   EXTERNAL_32BIT_TRIGGERS := visible-constructor-32
> -- 2.34.1 _______________________________________________ DTrace-devel 
> mailing list DTrace-devel at oss.oracle.com 
> https://oss.oracle.com/mailman/listinfo/dtrace-devel