[DTrace-devel] [PATCH REVIEW 4/6] tests: reduce timeout of very slow test

Kris Van Hees kris.van.hees at oracle.com
Wed Sep 29 14:23:27 PDT 2021


Reviewed-by: Kris Van Hees (kris.van.hees at oracle.com>

per the changes we discussed on list before, i.e. keeping the timeout the
same and marking it skip.

... and I added it to the 'dev' branch already.

On Thu, Sep 09, 2021 at 12:13:43PM +0100, Nick Alcock wrote:
> This test sets the timeout to a high value to fill a buffer that no
> longer applies to v2, and is marked @@xfail: dtv2.  Drop the timeout so
> we don't have to wait ten minutes on every test run for something we
> know will fail.
> 
> We can raise it again later if it seems necessary.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>  test/unittest/printa/tst.many.d | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Not really a fix, but saving nine minutes of test run time is a worthwhile
> thing anyway!
> 
> diff --git a/test/unittest/printa/tst.many.d b/test/unittest/printa/tst.many.d
> index 96b5f17dad3a..6b7462dfffa8 100644
> --- a/test/unittest/printa/tst.many.d
> +++ b/test/unittest/printa/tst.many.d
> @@ -10,7 +10,7 @@
>   * set the timeout to a high value to, in effect, disable it.
>   */
>  /* @@xfail: dtv2 */
> -/* @@timeout: 600 */
> +/* @@timeout: 60 */
>  
>  #pragma D option bufsize=32m
>  #pragma D option bufpolicy=fill
> -- 
> 2.33.0.256.gb827f06fa9
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel



More information about the DTrace-devel mailing list