[DTrace-devel] [PATCH REVIEW 4/6] tests: reduce timeout of very slow test

[Nick Alcock]

On 9 Sep 2021, Kris Van Hees said:

> On Thu, Sep 09, 2021 at 02:46:05PM -0400, Eugene Loh wrote:
>> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
>
> I disagree - not an acceptable solution.
>
> Instead, please mark this test as @@skip.  Since we do not support buffering
> policies other than ring (and possibly never will in this version), there is
> no point in running the test.  But I rather not change the test in case we do
> actually implement the fill buffering policy in the future.

Ah, good point. I didn't mark it as @@skip because @@skip is *obviously*
reserved for erratic tests or tests that crash the machine -- but since
we obviously can't have any of those anymore (right?) we might as well
use it for "tests that take ages, fail, and have next to no chance of
passing until we do something really major" (after which they would
hopefully not be overlooked?).

Will change.