[DTrace-devel] [PATCH REVIEW 2/4] htab: remove "based on a string" comment
Kris Van Hees
kris.van.hees at oracle.com
Tue Oct 12 14:38:39 PDT 2021
On Thu, Sep 09, 2021 at 12:13:21PM +0100, Nick Alcock wrote:
> The speculation code (upcoming) will have htabs of non-strings.
>
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>
... and added to my tree (with copyright year added).
> ---
> libdtrace/dt_htab.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Not much can usefully be split out of the speculation stuff:
> everything touches the consume loop. But this bit can be.
> It's really exciting.
>
> diff --git a/libdtrace/dt_htab.c b/libdtrace/dt_htab.c
> index e8e7c13b88f9..8e99987d06f1 100644
> --- a/libdtrace/dt_htab.c
> +++ b/libdtrace/dt_htab.c
> @@ -6,8 +6,7 @@
> */
>
> /*
> - * This file provides a generic hashtable implementation for structures that
> - * are hashed based on a string.
> + * This file provides a generic hashtable implementation.
> *
> * Code that uses this must provide a dt_htab_ops_t struct with helper
> * functions to be used for manipulating the hashtable. The following
> --
> 2.33.0.256.gb827f06fa9
>
>
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel
More information about the DTrace-devel
mailing list