[DTrace-devel] [PATCH REVIEW 3/4] fix a tiny comment niggle

[Kris Van Hees]

Hm, let's not do this.  If anything, we do need to set a default value for the
string size, so setting it to 256 is sensible (though we probably should
have a define for it somewhere rather than hardcoding the value).  But either
way the comment should be rewritten to reflect why we set the default size.

So, let's not do this patch and do one outside of this series to put in a
define and a proper comment.

On Thu, Sep 09, 2021 at 12:13:22PM +0100, Nick Alcock wrote:
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>  libdtrace/dt_open.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> This is just a stylistic nit I spotted while doing the specs work.
> 
> diff --git a/libdtrace/dt_open.c b/libdtrace/dt_open.c
> index 5908920d9042..867a61a30cc5 100644
> --- a/libdtrace/dt_open.c
> +++ b/libdtrace/dt_open.c
> @@ -781,7 +781,8 @@ dt_vopen(int version, int flags, int *errp,
>  	for (i = 0; i < DTRACEOPT_MAX; i++)
>  		dtp->dt_options[i] = DTRACEOPT_UNSET;
>  
> -	/* FIXME: the default value of strsize must be set.
> +	/*
> +	 * FIXME: the default value of strsize must be set.
>  	 * In legacy DTrace, the value was read from the kernel
>  	 * in dt_options_load().  When string handling is done,
>  	 * we will introduce a real solution suitable for this
> -- 
> 2.33.0.256.gb827f06fa9
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel