[DTrace-devel] [PATCH] Minor aggregations test cleanup

Kris Van Hees kris.van.hees at oracle.com
Mon Jan 4 22:42:02 PST 2021


On Thu, Dec 24, 2020 at 01:37:29PM -0500, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Typo in test name.  Nonsensical references to "clear" section.
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  test/unittest/aggs/err.D_CG_EXPR.from_expr.d                  | 2 +-
>  test/unittest/aggs/err.D_NORMALIZE_AGGARG.bad.d               | 2 +-
>  test/unittest/aggs/err.D_NORMALIZE_PROTO.bad.d                | 4 ++--
>  test/unittest/aggs/err.D_NORMALIZE_SCALAR.bad.d               | 4 ++--
>  ...o_amny_args.d => err.D_PROTO_LEN.quantize_too_many_args.d} | 0
>  5 files changed, 6 insertions(+), 6 deletions(-)
>  rename test/unittest/aggs/{err.D_PROTO_LEN.quantize_too_amny_args.d => err.D_PROTO_LEN.quantize_too_many_args.d} (100%)
> 
> diff --git a/test/unittest/aggs/err.D_CG_EXPR.from_expr.d b/test/unittest/aggs/err.D_CG_EXPR.from_expr.d
> index 1b176412..1b8c2d9e 100644
> --- a/test/unittest/aggs/err.D_CG_EXPR.from_expr.d
> +++ b/test/unittest/aggs/err.D_CG_EXPR.from_expr.d
> @@ -9,7 +9,7 @@
>   * ASSERTION:
>   *	Aggregations cannot be called from D expressions.
>   *
> - * SECTION: Aggregations/Clearing aggregations
> + * SECTION: Aggregations/Aggregations
>   *
>   *
>   */
> diff --git a/test/unittest/aggs/err.D_NORMALIZE_AGGARG.bad.d b/test/unittest/aggs/err.D_NORMALIZE_AGGARG.bad.d
> index ddfcad2a..224bed88 100644
> --- a/test/unittest/aggs/err.D_NORMALIZE_AGGARG.bad.d
> +++ b/test/unittest/aggs/err.D_NORMALIZE_AGGARG.bad.d
> @@ -10,7 +10,7 @@
>   * ASSERTION:
>   *	The first argument to normalize() should be an aggregation.
>   *
> - * SECTION: Aggregations/Clearing aggregations
> + * SECTION: Aggregations/Aggregations
>   *
>   *
>   */
> diff --git a/test/unittest/aggs/err.D_NORMALIZE_PROTO.bad.d b/test/unittest/aggs/err.D_NORMALIZE_PROTO.bad.d
> index c5f8a510..c8dc344e 100644
> --- a/test/unittest/aggs/err.D_NORMALIZE_PROTO.bad.d
> +++ b/test/unittest/aggs/err.D_NORMALIZE_PROTO.bad.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -10,7 +10,7 @@
>   * ASSERTION:
>   *	normalize() accepts 2 args - passing fewer is an error.
>   *
> - * SECTION: Aggregations/Clearing aggregations
> + * SECTION: Aggregations/Aggregations
>   *
>   *
>   */
> diff --git a/test/unittest/aggs/err.D_NORMALIZE_SCALAR.bad.d b/test/unittest/aggs/err.D_NORMALIZE_SCALAR.bad.d
> index cf40a3e9..0e14b77a 100644
> --- a/test/unittest/aggs/err.D_NORMALIZE_SCALAR.bad.d
> +++ b/test/unittest/aggs/err.D_NORMALIZE_SCALAR.bad.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -10,7 +10,7 @@
>   * ASSERTION:
>   *	The second argument to normalize() should be a scalar.
>   *
> - * SECTION: Aggregations/Clearing aggregations
> + * SECTION: Aggregations/Aggregations
>   *
>   *
>   */
> diff --git a/test/unittest/aggs/err.D_PROTO_LEN.quantize_too_amny_args.d b/test/unittest/aggs/err.D_PROTO_LEN.quantize_too_many_args.d
> similarity index 100%
> rename from test/unittest/aggs/err.D_PROTO_LEN.quantize_too_amny_args.d
> rename to test/unittest/aggs/err.D_PROTO_LEN.quantize_too_many_args.d
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel



More information about the DTrace-devel mailing list