[DTrace-devel] [PATCH] Test min/max aggregation initialization

[Kris Van Hees]

On Thu, Dec 24, 2020 at 12:53:36PM -0500, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> The min and max aggregation functions have a special code path in
> which initial values are set to max and min values, respectively.
> All other aggregation functions expect zeroes for initialization.
> The min and max tests include zeroes as values, and therefore do
> not detect if the special code path is not used.
> 
> Change the min and max tests to use values of a particular sign
> (positive by default, negative in the _neg variants) to exercise
> the special code path.
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  test/unittest/aggs/tst.max.d     | 2 +-
>  test/unittest/aggs/tst.max_neg.d | 2 +-
>  test/unittest/aggs/tst.max_neg.r | 2 +-
>  test/unittest/aggs/tst.min.d     | 2 +-
>  test/unittest/aggs/tst.min.r     | 2 +-
>  test/unittest/aggs/tst.min_neg.d | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/test/unittest/aggs/tst.max.d b/test/unittest/aggs/tst.max.d
> index 76e52c96..6c27aee0 100644
> --- a/test/unittest/aggs/tst.max.d
> +++ b/test/unittest/aggs/tst.max.d
> @@ -17,7 +17,7 @@
>  
>  BEGIN
>  {
> -	i = 0;
> +	i = 100;
>  }
>  
>  tick-10ms
> diff --git a/test/unittest/aggs/tst.max_neg.d b/test/unittest/aggs/tst.max_neg.d
> index 56d29475..1c9bd5c4 100644
> --- a/test/unittest/aggs/tst.max_neg.d
> +++ b/test/unittest/aggs/tst.max_neg.d
> @@ -17,7 +17,7 @@
>  
>  BEGIN
>  {
> -	@ = max(0);
> +	@ = max(-100);
>  	@ = max(-900);
>  	exit(0);
>  }
> diff --git a/test/unittest/aggs/tst.max_neg.r b/test/unittest/aggs/tst.max_neg.r
> index 8d23188f..61619bd0 100644
> --- a/test/unittest/aggs/tst.max_neg.r
> +++ b/test/unittest/aggs/tst.max_neg.r
> @@ -1,2 +1,2 @@
>  
> -                0
> +             -100
> diff --git a/test/unittest/aggs/tst.min.d b/test/unittest/aggs/tst.min.d
> index 60b4fdd6..f2c3865d 100644
> --- a/test/unittest/aggs/tst.min.d
> +++ b/test/unittest/aggs/tst.min.d
> @@ -17,7 +17,7 @@
>  
>  BEGIN
>  {
> -	i = 0;
> +	i = 100;
>  }
>  
>  tick-10ms
> diff --git a/test/unittest/aggs/tst.min.r b/test/unittest/aggs/tst.min.r
> index 8d23188f..e943a29e 100644
> --- a/test/unittest/aggs/tst.min.r
> +++ b/test/unittest/aggs/tst.min.r
> @@ -1,2 +1,2 @@
>  
> -                0
> +              100
> diff --git a/test/unittest/aggs/tst.min_neg.d b/test/unittest/aggs/tst.min_neg.d
> index b01689f0..d76ceca1 100644
> --- a/test/unittest/aggs/tst.min_neg.d
> +++ b/test/unittest/aggs/tst.min_neg.d
> @@ -17,7 +17,7 @@
>  
>  BEGIN
>  {
> -	@ = min(0);
> +	@ = min(-100);
>  	@ = min(-900);
>  	exit (0);
>  }
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel