[rds-devel] [External] : Re: [PATCH net-next v1] selftest: rds: add tools/testing/selftests/net/rds/config

[Paolo Abeni]

On 3/17/26 12:58 AM, Allison Henderson wrote:
> This patch adds an rds selftest config.  

Why? what improvement produces or what issues does that address?

> diff --git a/tools/testing/selftests/net/rds/config b/tools/testing/selftests/net/rds/config
> new file mode 100644
> index 000000000000..103f9d941d10
> --- /dev/null
> +++ b/tools/testing/selftests/net/rds/config
> @@ -0,0 +1,5 @@
> +CONFIG_RDS=y
> +CONFIG_RDS_TCP=y
> +CONFIG_NET_NS=y
> +CONFIG_VETH=y
> +CONFIG_NET_SCH_NETEM=y
> diff --git a/tools/testing/selftests/net/rds/config.sh b/tools/testing/selftests/net/rds/config.sh
> index 791c8dbe1095..7cf56ee8882f 100755
> --- a/tools/testing/selftests/net/rds/config.sh
> +++ b/tools/testing/selftests/net/rds/config.sh
> @@ -24,7 +24,7 @@ while getopts "g" opt; do
>    esac
>  done
>  
> -CONF_FILE="tools/testing/selftests/net/config"
> +CONF_FILE="tools/testing/selftests/net/rds/config"
>  
>  # no modules
>  scripts/config --file "$CONF_FILE" --disable CONFIG_MODULES

This looks wrong?!? The script is going to update the config file which
is under git control. You probably want to copy the default config in a
tmp file file, edit the latter and add it to .gitignore and EXTRA_CLEAN.

The issue looks pre-existent, but since you are touching this part...

/P