[rds-devel] [RESEND PATCH] mm: Use spin_lock_irqsave in __set_page_dirty_nobuffers

Andrew Morton akpm at linux-foundation.org
Fri Jan 21 00:18:04 PST 2011

On Mon, 10 Jan 2011 22:15:34 -0800 Andy Grover <andy.grover at oracle.com> wrote:

> RDS is calling set_page_dirty from interrupt context,

yikes.  Whatever possessed you to try that?

> @@ -1155,11 +1155,12 @@ int __set_page_dirty_nobuffers(struct page *page)

__set_page_dirty_buffers(): bug, takes mapping->private_lock in irq context
                            bug, __set_page_dirty() reenables IRQs
ceph_set_page_dirty():      more bugs than I care to enumerate
nilfs_set_file_dirty():	    bug, takes sbi->s_inode_lock in IRQ context

More information about the rds-devel mailing list