[rds-devel] [PATCH 4/5] rds: stop including asm-generic/bitops/le.h directly
davem at davemloft.net
Fri Oct 8 11:59:00 PDT 2010
From: Andy Grover <andy.grover at oracle.com>
Date: Fri, 08 Oct 2010 11:55:55 -0700
> On 10/08/2010 03:03 AM, Akinobu Mita wrote:
>> asm-generic/bitops/le.h is only intended to be included directly from
>> asm-generic/bitops/ext2-non-atomic.h or asm-generic/bitops/minix-le.h
>> which implements generic ext2 or minix bit operations.
>> This stops including asm-generic/bitops/le.h directly and use ext2
>> non-atomic bit operations instead.
>> An alternative approach is introducing little endian bit operations
>> in linux/bitops.h. But it needs to touch more files than this change
>> - generic___set_le_bit(off, (void *)map->m_page_addrs[i]);
>> + ext2_set_bit(off, (void *)map->m_page_addrs[i]);
> I'd like a solution that doesn't have rds calling a function starting
> with ext2_. Seems wrong.
More information about the rds-devel