[rds-devel] pull/review tcp fixes

Zach Brown zach.brown at oracle.com
Fri Jun 4 14:48:35 PDT 2010


Hey Andy,

It looks like it was relatively simple to get the basic TCP transport functioning again.  The only real damage was calling the xmit path under a spinlock.  With that fixed it seems to work.

The first two patches are trivial debugging fallout.

The third patch is the meat of it.  If you could review it before pulling, that'd be super.  Removing c_send_generation makes sense to me, but maybe I'm missing something.

The following changes since commit 9acf72f6f7de370bbe75f612d0add59ddff23389:
  Andy Grover (1):
        cmason: use friendly gfp masks for prefill

are available in the git repository at:

  git://oss.oracle.com/git/zab/ofed-1.5-linux-2.6.git fix-tcp-for-agrover

Zach Brown (3):
      rds: remove unused rds_send_acked_before()
      rds: block ints when acquiring c_lock in rds_conn_message_info()
      rds: fix rds_send_xmit() serialization

 net/rds/connection.c |   24 ++++-------
 net/rds/ib_send.c    |    2 +-
 net/rds/rds.h        |    6 +--
 net/rds/send.c       |  111 +++++++++++++++++++------------------------------
 net/rds/threads.c    |    2 +-
 5 files changed, 55 insertions(+), 90 deletions(-)




More information about the rds-devel mailing list