[rds-devel] initial patches to support device migration

Andy Grover andy.grover at oracle.com
Thu Apr 22 12:13:44 PDT 2010


Zach Brown wrote:
> These patches start to support the notion of having connections live
> across device removal and addition.  We disconnect connections when
> devices are removed, instead of destroying them, and we try and
> re-establish those connections as devices come back.
> 
> The biggest obstacle was tearing down the device safely in the
> presence of racing references of the rds_ibdev device struct.  That's
> the first patch and the bulk of the patch series.  The rest just
> relies on the existing connection management code.
> 
> Basic tests seem to work, though it looks like we'll want to refine
> some of the reconnection logic.

https://bugs.openfabrics.org/show_bug.cgi?id=1936 ? Or a separate issue?

> Thoughts?

Looks good, just a couple patch-related nits. Please prepend "RDS:" or 
"RDS/IB:" as appropriate to patch subjects. Also some changes unrelated 
to the main focus of the first patch (kzalloc and the ib_send.c 
cleanups) may want to go in separate patches.

Thanks! -- Regards -- Andy



More information about the rds-devel mailing list