[rds-devel] [PATCH 6/9] RDS: Fix ordering in a conditional
Andy Grover
andy.grover at oracle.com
Mon Mar 30 11:44:50 PDT 2009
Putting the constant first is a supposed "best practice" that actually makes
the code harder to read.
Signed-off-by: Andy Grover <andy.grover at oracle.com>
---
net/rds/rdma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index eaeeb91..584eac3 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -155,7 +155,7 @@ static int rds_pin_pages(unsigned long user_addr, unsigned int nr_pages,
nr_pages, write, 0, pages, NULL);
up_read(¤t->mm->mmap_sem);
- if (0 <= ret && (unsigned) ret < nr_pages) {
+ if (ret > 0 && (unsigned) ret < nr_pages) {
while (ret--)
put_page(pages[ret]);
ret = -EFAULT;
--
1.5.6.3
More information about the rds-devel
mailing list