[rds-devel] [PATCH 1/4] rds/ib: remove IB_SEND_SOLICITED bit usage from RDMA posting

Or Gerlitz ogerlitz at voltaire.com
Mon Jan 14 01:54:00 PST 2008


IB_SEND_SOLICITED is irrelevant for RDMA work requests as there no matching
completion is generated at the remote side.

Signed-off-by: Or Gerlitz <ogerlitz at voltaire.com>

Index: ofa_1_3_kernel-20080113-0200/net/rds/ib_send.c
===================================================================
--- ofa_1_3_kernel-20080113-0200.orig/net/rds/ib_send.c
+++ ofa_1_3_kernel-20080113-0200/net/rds/ib_send.c
@@ -574,7 +574,7 @@ int rds_ib_xmit_rdma(struct rds_connecti
 		 */
 		if (ic->i_unsignaled_wrs-- == 0) {
 			ic->i_unsignaled_wrs = rds_ib_sysctl_max_unsig_wrs;
-			send->s_wr.send_flags = IB_SEND_SIGNALED | IB_SEND_SOLICITED;
+			send->s_wr.send_flags = IB_SEND_SIGNALED;
 		}

 		send->s_wr.opcode = op->r_write ? IB_WR_RDMA_WRITE : IB_WR_RDMA_READ;
@@ -623,7 +623,7 @@ int rds_ib_xmit_rdma(struct rds_connecti

 	/* if we finished the message then send completion owns it */
 	if (scat == &op->r_sg[op->r_count]) {
-		prev->s_wr.send_flags = IB_SEND_SIGNALED | IB_SEND_SOLICITED;
+		prev->s_wr.send_flags = IB_SEND_SIGNALED;
 		prev->s_op = op;
 	}





More information about the rds-devel mailing list