[rds-devel] Re: [PATCH] workaround for RDMA error disconnects

[Or Gerlitz]

Olaf Kirch wrote:
> On Wednesday 30 January 2008 15:50, Or Gerlitz wrote:
>>> @@ -512,35 +512,38 @@ void rds_ib_conn_shutdown(struct rds_connection *conn)
>>> +		/* Always move the QP to error state */
>>> +		if (ic->i_cm_id->qp) {
>>> +			qp_attr.qp_state = IB_QPS_ERR;
>>> +			err = ib_modify_qp(ic->i_cm_id->qp, &qp_attr, IB_QP_STATE);
>>> +			if (err) {
>>> +				printk(KERN_WARNING "rds_ib_conn_shutdown: failed to"
>>> +					   " modify QP to ERR state: id %p qp %p err %d\n",
>>> +					   ic->i_cm_id, ic->i_cm_id->qp, err);
>>>  			}

>> Are you suspecting that the RDMA-CM does not move the QP state even when 
>> rdma_disconnect returned 0 ?

> That code has been there since I started to hack on the code; I don't know
> who put it there and why - I just moved it around. So maybe someone was
> just overly cautious.

OK, I will mark myself to send a patch that clean it

Or