[rds-devel] [PATCH] Removed extra call to the rb_erase.

Vladimir Sokolovsky vlad at dev.mellanox.co.il
Sun Nov 18 23:55:02 PST 2007


     RDS: rb_erase called twice to remove the same rkey from the rb_tree.
         Removed extra call to the rb_erase.

     Signed-off-by: Vladimir Sokolovsky <vlad at mellanox.co.il>

diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index 9dd3855..e224308 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -324,7 +324,6 @@ int rds_free_mr(struct rds_sock *rs, char __user *optval, int optlen)
         spin_lock(&rs->rs_rdma_lock);
         mr = rds_mr_tree_walk(&rs->rs_rdma_keys, args.key, NULL);
         if (mr) {
-               rb_erase(&mr->r_rb_node, &rs->rs_rdma_keys);
                 trans_private = mr->r_trans_private;
                 mr->r_trans_private = NULL;
                 atomic_dec(&mr->r_refcount);


Regards,
Vladimir



More information about the rds-devel mailing list